As Jeff Bonwick said, open sourced code is nothing compared to the fact that all design discussions and decisions suddenly happen in the public (loosely paraphrased). This is a great wave to ride and I have jumped on it
when it was not really small so I have at least posted the webrev pointer for initial Netcat integration (CR 4664622) to the opensolaris-code mailing list (which is roughly the equivalent of freebsd-hackers, openbsd-tech or similar mailing lists)
to get some code review comments.
Since then couple of things changed. Thanks to
Dan Price and others
to upload webrevs to cr.opensolaris.org.
I have started using the service so the new and official place for the Netcat webrev is
The webrev has moved location but what I said in the opensolaris-code post still holds
Any constructive notes regarding the code are welcome. (I am mainly
looking for functional/logic errors, packaging flaws or parts of code
which could mismatch the PSARC case)
The following things could help any potential code reviewer:
The conclusion for non code reviewers ? I hope it is clear the in (Open)Solaris land
we value quality and transparency. Peer reviews and architectural reviews are just
(albeit crucial) pieces which help to achieve that goal.