Timezones for cron code review request

I've got the webrevs ready for cron supporting time zones. The slight delay was finding a version of webrev that was aware of mecurial which I found on http://cr.grommit.com/~stevel/webrev_fixes/raw_files/new/usr/src/tools/scripts/webrev.sh. Even this though leaves something to be desired as mercurial insists that any new file that it sees is something that is part of the putback. So if you run this twice it produces a webrev of the webrev. Somewhat confusing but I'm sure we will get sorted out as mercurial moves into the mainstream. For similar reasons I had to pull a new source tree and merge my changes so that mercurial really only saw the things I had really touched and not every file that I had built.

Anyway back on topic. The webrev for:

PSARC 2007/503: crontab entry environment variables
6518038 cron & crontab should support multiple timezone

Is here: http://cr.opensolaris.org/~cjg/cron/webrev/. The code review request has been posted to the OpenSolaris Code alias. Please respond to the review there.

Comments:

Chris, I downloaded the onbld package from OS.o, which seems to contain a version of webrev that works well with Mercurial.

I had to upgrade to the SUNWmercurial package from OS.o too as the Blastwave version is too old to work with webrev.

Posted by Trevor Watson on November 19, 2007 at 08:35 AM GMT #

Post a Comment:
Comments are closed for this entry.
About

This is the old blog of Chris Gerhard. It has mostly moved to http://chrisgerhard.wordpress.com

Search

Archives
« April 2014
MonTueWedThuFriSatSun
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
    
       
Today